search

oursky / likecoin-chain

LikeCoin chain node
https://likecoin.bigdipper.live
GNU General Public License v3.0
1 stars 2 forks source link

[NFT] Add versioning to protobuf schemas #139

Closed elise-ng closed 2 years ago

elise-ng commented 2 years ago

use v1beta1 or v1

mitchellchou commented 2 years ago

need to do once before testnet, will affect other nft developer

elise-ng commented 2 years ago

Some issue with proceeding:

The best practice is to name the package likechain.likenft.v1 & put the proto files in /proto/likechain/likenft/v1/xxx.proto, & rest api path /likechain/likenft/v1/xxx (from observation big chains like osmosis / evmos / cro follows this)

But this would not work with ignite cli (starport): it expects proto files to be placed in /proto/likenft, and package name likecoin.likechain.likenft...

There seems to be no option for custom proto path or module name; dev will need workaround by adding a temporary simlink from the expected path to the actual proto path when scaffolding + rename the generated package name / rest api path

(Dev will have to rename the package line anyways, in order to align with iscn's likechain.iscn format; the biggest pain point is to add simlink everytime scaffold command is used)

@Rico-Wong @rickmak any opinion on this?

mitchellchou commented 2 years ago

add instruction in readme