oursky / likecoin-chain

LikeCoin chain node
https://likecoin.bigdipper.live
GNU General Public License v3.0
1 stars 2 forks source link

Improve rest api paths for likenft queries #325

Closed elise-ng closed 2 years ago

elise-ng commented 2 years ago

Ref oursky/likecoin-chain#275

One question, would you prefer:

hochiw commented 2 years ago

don't really have a strong preference but I guess /iscn-classes/{iscn_id_prefix} and /account-classes/{account} looks better

rickmak commented 2 years ago

Let do /iscn-classes/{iscn_id_prefix} and /account-classes/{account}

Since we won't have use-case for returning all Classes, making the inheritance appear in the API is not wise.

elise-ng commented 2 years ago

updated to /iscn_classes/{iscn_id_prefix} and /account_classes/{account}

elise-ng commented 2 years ago

on second thought we could also do /iscn/{iscn id}/classes and /account/{addr}/classes nvm, wasn't thinking clearly, we have the list all queries as well and this pattern won't serve that usage

currently for the reverse query it's /classes/{class id}/iscn and classes/{class id}/account