search

oursky / mockuphone.com

Apache License 2.0
2 stars 4 forks source link

[MUP-102] Upload image here text #66

Closed chankiyu22 closed 1 month ago

chankiyu22 commented 1 month ago
Screen Shot 2024-06-24 at 19 04 31 Screen Shot 2024-06-24 at 19 04 29 Screen Shot 2024-06-24 at 19 04 27
Screen Shot 2024-06-24 at 19 04 26 Screen Shot 2024-06-24 at 19 04 25 Screen Shot 2024-06-24 at 19 04 23
chankiyu22 commented 1 month ago
Just found from meta the samsung galaxy s5 has no "samsung" text on it :sosad:. Samsung Galaxy Note 5 Black Samsung Galaxy Note 5 Gold Samsung Galaxy Note 5 Pink Samsung Galaxy Note 5 Silver Titanium Samsung Galaxy Note 5 White
pkong-ds commented 1 month ago

Just found from meta the samsung galaxy s5 has no "samsung" text on it :sosad:.

Maybe it was intentional to avoid any legal problems?

chankiyu22 commented 1 month ago
  1. S4 text not center aligned

Found it is because the screen S4 is not centre aligned in the image. The centre is a bit off.

          "coords": [
            [680, 400],
            [1367, 400],
            [1367, 1603],
            [680, 1603]
          ],

(1367 + 680) /2 = 1,023.5.

So the assumption of centre does not hold :sosad:. May need to supply the image size optionally to the device info config.

chankiyu22 commented 1 month ago

@pkong-ds Can review now :sosad: