search

ourzora / mint-page-template

mint-page-template-iota.vercel.app
MIT License
71 stars 33 forks source link

MintSuccess throws error on 3D files #18

Open madjin opened 1 year ago

madjin commented 1 year ago

On MintSuccess the browser requests the glb but then previews the Image instead Test site: https://testnet.zora.co/collections/0x2f3dfeb8cc4bf5ded8797652186631bebb6e2bf3/mint

boom-zora

As you can see, MintSuccess calls ImageRenderer and tries to preview the glb. It would be OK if it did ImageRenderer, and we just go to another marketplace to see the full 3D reveal like Opensea, but right now this small bug breaks the experience. image

There already is Model.tsx, a nft component for viewing glTF 3D models: https://github.com/ourzora/nft-components/blob/ccada1898a2204735c4b19e6360a97c21ebdc6b1/src/content-components/Model.tsx

The ideal fix would be to use Model.tsx to see the Model (animation_url) instead of an image so that the preview / reveal can have greater consistency across frontends / marketplaces like Opensea, but if that's too much it would be fine to atleast to see the image after a successful mint

6d47ff4145d48829281226af2c45f394

gm3 commented 1 year ago

image

Also shows up on the collection page

gm3 commented 1 year ago

image