search

ourzora / nft-components

NFT Rendering Components
GNU General Public License v3.0
100 stars 36 forks source link

FullComponents AuctionInfo to show market info once auction is over. #105

Closed dblodorn closed 2 years ago

dblodorn commented 2 years ago

Currently when using the FullComponents.AuctionInfo component shows sold for info inconsistently: I believe this is located to NFT Components and not the Iframe Embed codebase.

Perhaps we should revisit this component, and add some config options for what it renders for different market states.

Not showing here: https://embed.zora.co/config/0x364547ADfc7a180744D762056Df35eeaEa803EC4/1

Although showing here: https://embed.zora.co/config/foundation/105683

Screen Shot 2021-11-30 at 5 15 08 PM

Screen Shot 2021-11-30 at 5 11 13 PM

Screen Shot 2021-11-30 at 5 11 58 PM

dblodorn commented 2 years ago

@iainnash this is tied to the useBetaIndexer flag

https://user-images.githubusercontent.com/7268786/144157128-c52cd99f-86a4-4362-a525-69c52b30d108.mov

iainnash commented 2 years ago

The useBetaIndexer flag shouldn't affect this rendering, will look into this bug.

iainnash commented 2 years ago

Believe this has been fixed.