search

ourzora / nft-components

NFT Rendering Components
GNU General Public License v3.0
100 stars 36 forks source link

NFT-Components Doesn't Work with React 18 because package is shipping React 17 to users #138

Open benschac opened 2 years ago

benschac commented 2 years ago

After importing @zora/nft-components package in https://github.com/benschac/create-zora-graphql-app/ I got an error. 

Unhandled Runtime Error
Error: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
1. You might have mismatching versions of React and the renderer (such as React DOM)
2. You might be breaking the Rules of Hooks
3. You might have more than one copy of React in the same app
See https://reactjs.org/link/invalid-hook-call for tips about how to debug and fix this problem.

Which 3 seemed like the likely culprit.

I then: npm ls react and confirmed @zora/nft-components was the only package that shipped with react v.17

zora-hack@0.1.0 /Users/benjaminschachter/zora-hack
├─┬ @apollo/client@3.6.6
│ └── react@18.1.0 deduped
├─┬ @rainbow-me/rainbowkit@0.2.3
│ ├─┬ react-remove-scroll@2.5.3
│ │ ├─┬ react-remove-scroll-bar@2.3.3
│ │ │ └── react@18.1.0 deduped
│ │ ├─┬ react-style-singleton@2.2.1
│ │ │ └── react@18.1.0 deduped
│ │ ├── react@18.1.0 deduped
│ │ ├─┬ use-callback-ref@1.3.0
│ │ │ └── react@18.1.0 deduped
│ │ └─┬ use-sidecar@1.1.2
│ │   └── react@18.1.0 deduped
│ └── react@18.1.0 deduped
├─┬ @zoralabs/nft-components@1.1.0
│ ├─┬ react-dom@17.0.2
│ │ └── react@17.0.2 deduped
│ ├── react@17.0.2
│ └─┬ swr@0.5.7
│   └── react@17.0.2 deduped
├─┬ @zoralabs/nft-hooks@1.1.7
│ ├── react@18.1.0 deduped
│ └─┬ swr@1.3.0
│   └── react@17.0.2
├─┬ next@12.1.6
│ ├── react@18.1.0 deduped
│ └─┬ styled-jsx@5.0.2
│   └── react@18.1.0 deduped
├─┬ react-dom@18.1.0
│ └── react@18.1.0 deduped
├── react@18.1.0
└─┬ wagmi@0.4.10
  ├─┬ @wagmi/core@0.3.7
  │ └─┬ zustand@4.0.0-rc.1
  │   └── react@18.1.0 deduped
  ├─┬ react-query@4.0.0-beta.23
  │ └── react@18.1.0 deduped
  ├── react@18.1.0 deduped
  └─┬ use-sync-external-store@1.1.0
    └── react@18.1.0 deduped

To test that @zora/nft-components was the culprit I added selective version resolutions and bumped @zora/nft-components to v18 with the rest of my project.

https://github.com/benschac/create-zora-graphql-app/blob/main/package.json#L25

Now the components work and the page is loading.

The simplest solution here seems to not ship a version of react with @zora/nft-components