ourzora / zdk

MIT License
107 stars 42 forks source link

Error at using some enums as runtime values #96

Open Enderlook opened 1 year ago

Enderlook commented 1 year ago

The file types.d.ts uses export type to export some enums. This prevents consumers from using those enums as values at runtime. Shouldn't they be exported with export instead?

I found this happens with SortDirection and TokenSortKey due to this line:

https://github.com/ourzora/zdk/blob/e70abf90524ad3b6460a097f0973433e779aa469/src/types.ts#L1-L15