search

ourzora / zora-docs

https://docs.zora.co
120 stars 93 forks source link

Fix Incorrect Link Address #139

Closed joaolago1113 closed 10 months ago

joaolago1113 commented 11 months ago

Description

This pull request resolves two key issues within the commits: one concerning the ERC-20 contract initialization and the CompatibilityFallbackHandler address in the Gnosis Safe (L2) section.

The primary problem stems from an incorrect link address in the CompatibilityFallbackHandler, which has been rectified. Additionally, a minor error in the Approve Tokens to Zora tutorial has been corrected, where the variable nftContractAddress was erroneously used instead of erc20ContractAddress.

Commits

Commit 45708c2d1584cb8b477d21ec94493a2b60c31d95

Diff:

-| CompatibilityFallbackHandler | [0xf48f2B2d2a534e402487b3ee7C18c33Aec0Fe5e4](https://explorer.zora.energy/address/0xf48f2b2d2a535000000000000000000000000000) | yes      |
+| CompatibilityFallbackHandler | [0xf48f2B2d2a534e402487b3ee7C18c33Aec0Fe5e4](https://explorer.zora.energy/address/0xf48f2B2d2a534e402487b3ee7C18c33Aec0Fe5e4) | yes      |

Commit 47f67945d80cb5a13de6f34a6f751433b1ac8c29

Diff:

-const erc20Contract = IERC20__factory.connect(nftContractAddress, signer);
+const erc20Contract = IERC20__factory.connect(erc20ContractAddress, signer);

Thank you for considering and merging this pull request. Your collaboration is greatly appreciated.

vercel[bot] commented 11 months ago

@joaolago1113 is attempting to deploy a commit to the Zora Team on Vercel.

A member of the Team first needs to authorize it.

iainnash commented 10 months ago

Thank you for these fixes