Incorrect initializing of RewardsSettings in computeRewards function
Motivation and Context
Market reward and Zora reward were mixed up in places.
Currently, it brings no impace since MARKET_REWARD and ZORA_REWARD are the same in ZoraTimedSaleStrategyConstants, so this bug turned out to be unnoticed.
But if you would like to change these values in the future, it may lead to wrong behaviour and loss of funds for Zora
Does this change the ABI/API?
[ ] This changes the ABI/API
What tests did you add/modify to account for these changes
Types of changes
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New module / feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Checklist:
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I added a changeset to account for this change
Reviewer Checklist:
[ ] My review includes a symposis of the changes and potential issues
[ ] The code style is enforced
[ ] There are no risky / concerning changes / additions to the PR
Description
Incorrect initializing of
RewardsSettings
incomputeRewards
functionMotivation and Context
Market reward and Zora reward were mixed up in places. Currently, it brings no impace since
MARKET_REWARD
andZORA_REWARD
are the same inZoraTimedSaleStrategyConstants
, so this bug turned out to be unnoticed. But if you would like to change these values in the future, it may lead to wrong behaviour and loss of funds for ZoraDoes this change the ABI/API?
What tests did you add/modify to account for these changes
Types of changes
Checklist:
Reviewer Checklist: