ourzora / zora-protocol

Monorepo for Zora Protocol (contracts & sdks)
MIT License
116 stars 72 forks source link

TimedSaleStrategy rewards bug fix #433

Closed the-laziest closed 2 weeks ago

the-laziest commented 1 month ago

Description

Incorrect initializing of RewardsSettings in computeRewards function

Motivation and Context

Market reward and Zora reward were mixed up in places. Currently, it brings no impace since MARKET_REWARD and ZORA_REWARD are the same in ZoraTimedSaleStrategyConstants, so this bug turned out to be unnoticed. But if you would like to change these values in the future, it may lead to wrong behaviour and loss of funds for Zora

Does this change the ABI/API?

What tests did you add/modify to account for these changes

Types of changes

Checklist:

Reviewer Checklist:

iainnash commented 1 month ago

Thanks for bringing this up! We have a fix coming that also changes some other things.