ousnius / BodySlide-and-Outfit-Studio

BodySlide and Outfit Studio, a tool to convert, create, and customize outfits and bodies for Bethesda games.
GNU General Public License v3.0
293 stars 64 forks source link

Custom bones don't appear right with "Show Bones" or "Show Nodes" #440

Closed sts1skj closed 2 years ago

sts1skj commented 2 years ago

Custom bones don't appear at all when you turn on "Show Bones". They do appear when you turn on "Show Nodes", but their location doesn't update when you change them with "Edit Bone".

sts1skj commented 2 years ago

Pull request #441 fixes the first problem: custom bones don't appear.

The second problem is apparently because NiNodes are not updated until the NIF is saved. Until then, the copy of NiNode data in AnimSkeleton can be out of sync with the copy in NifFile. I don't know why OS works this way, so I don't know whether it makes sense to fix this problem.

ousnius commented 2 years ago

Pull request #441 fixes the first problem: custom bones don't appear.

The second problem is apparently because NiNodes are not updated until the NIF is saved. Until then, the copy of NiNode data in AnimSkeleton can be out of sync with the copy in NifFile. I don't know why OS works this way, so I don't know whether it makes sense to fix this problem.

Yes, I knew about the second problem and decided it's too dangerous fixing it/changing that behavior.