search

ousnius / nifly

C++ NIF library for the Gamebryo/NetImmerse File Format
GNU General Public License v3.0
52 stars 23 forks source link

Mostly memory management #2

Closed Guekka closed 3 years ago

Guekka commented 3 years ago

For review, I suggest looking at each commit individually.

For 05db039 (memory management), I suggest you do not look at the headers. It's only noise, the real changes are in the source files

Going to test the changes soon

ousnius commented 3 years ago

@Guekka Please remove "Utils.hpp" and put the changes into "NifUtil.hpp" instead. No need for two util headers.

Additionally, don't include "Utils.hpp" in any other header files, we don't want to force the templates on anyone using nifly. If necessary, move GetBlockID to a source file and split the clone stuff into its own header so that you can include it in other headers if necessary.

Guekka commented 3 years ago

@ousnius Is it good like that?