oussdag / csipsimple

Automatically exported from code.google.com/p/csipsimple
0 stars 0 forks source link

double tap screen lock modification #214

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I don't like the double tap screen lock currently used in csipsimple. It 
annoying to have to double tap everytime the call starts to access the phone 
features or disconnect a call. I propose we change it to a slide lock like in 
sipdroip. As the call starts the slide lock closes and prevents false screen 
contacts. Then a simple slide opens the phone panel and/or disconnects the 
call. While csipsimple is by far better than sipdrod, this is one 
implementation where sipdroid is more elegant.

Original issue reported on code.google.com by dcitele...@gmail.com on 13 Sep 2010 at 9:49

GoogleCodeExporter commented 9 years ago
Well, several points here :
* There is actually a bug with locker overlay if you have a proximity sensor on 
your device. Note that with a proximity sensor, you should never have to bother 
with the locker overlay (when the bug will be fixed).

* The double tap to is the method used by android native application. So that's 
much more intuitive for user than the implementation done by sipdroid IMHO. One 
of the key point of csipsimple user interfaces is to try to match look&feel of 
Froyo (and I have a lot of good feedback about it). As a result, will not 
change this implementation.

* However ... , CSipSimple will be open to development of "themes" apps. So it 
will be possible to have another app (/plugin) that override the in call 
screen. If there is developers interested in it, it will be possible for them 
to implement the in call screen they want... And why not the sipdroid's one ;)

Original comment by r3gis...@gmail.com on 14 Sep 2010 at 6:58

GoogleCodeExporter commented 9 years ago
With some reluctance, I second dcitelecom's request. For me, this is not really 
important because I have proximity sensor and never have to double-tap or 
slide. But, it once happened that I put the device in the shirt pocket while on 
call and it got inadvertantly "doble-tapped" as I was moving, and unlocked. 
Where it a slide lock, accidental unlock would be less probable.

Original comment by egcros...@gmail.com on 16 Sep 2010 at 7:43

GoogleCodeExporter commented 9 years ago
While the double tap might be standard in Android, it's not necessarily user 
friendly. You have to tap at a certain speed or it does not work and sometimes 
I have to double tap several times before I can unlock the app. Moreover none 
of the options like dial pad, speaker, bluetooth, etc... are accessible unless 
you double tap and then you can't double tap again to lock the screen. A slide 
allows to open and close the screen. Sipdroid also allows to slide the options 
out. Maybe that would be something to consider. Display a little tab on the 
scree that slides out to access the options so we can enter digits and switch 
to speaker phone without unlocking the screen.

Original comment by dcitele...@gmail.com on 16 Sep 2010 at 9:17

GoogleCodeExporter commented 9 years ago
Well ok.
I'll implement a slide locker (like the android screenlocker and the current 
widget to take/decline calls) instead of the double tap.

Original comment by r3gis...@gmail.com on 17 Sep 2010 at 3:45

GoogleCodeExporter commented 9 years ago
Done, 0.00-12-33 available on downloads.

Let me know if more useable like that. I added the option to quickly hangup.

Original comment by r3gis...@gmail.com on 19 Sep 2010 at 6:14

GoogleCodeExporter commented 9 years ago
12-33 causes force close on HTC Hero with Android 2.1 (VillainRom 12) when 
trying to define the password of the SIP account. I tried basic and advanced 
mode.

Original comment by dcitele...@gmail.com on 19 Sep 2010 at 9:03

GoogleCodeExporter commented 9 years ago
Oups sorry,
0.00-12-34 fix it :). (Was for a good cause ;)... you'll see new password 
interface)

Original comment by r3gis...@gmail.com on 19 Sep 2010 at 9:17

GoogleCodeExporter commented 9 years ago
Yes. I like it better this way. The slide works better (for me) than double 
tap. Screen should lock faster though. Needs also ability to re-lock when 
unlocked. E.g. to call a company with auto attendent, you need to unlock the 
screen to navigate through the directory via dtmf input and after you get 
transferred to the person you want to talk, you need to lock the screen again 
to prevent unwanted screen inputs. Another reason would be 

Original comment by dcitele...@gmail.com on 20 Sep 2010 at 12:38

GoogleCodeExporter commented 9 years ago
In 0.00-12-35 if you are not using a nexus one on wifi and you have a proximity 
sensor, screen will goes off on proximity.

Original comment by r3gis...@gmail.com on 20 Sep 2010 at 6:45

GoogleCodeExporter commented 9 years ago
1. HTC Hero does not have a proximity sensor but apparently it's possible to 
use the light sensor instead. Look at this link.
http://www.androlib.com/android.application.tomreay-proxsensor-xnxi.aspx
2. After switching to speaker phone it takes more than 10 seconds for screen to 
auto lock again. Maybe shorten time delay?

Original comment by dcitele...@gmail.com on 20 Sep 2010 at 8:17

GoogleCodeExporter commented 9 years ago
Really interesting link. I'll have a closer look to that implementation. I'll 
probably *not* implement that in a near future but when I'll get time maybe. 
That's a nice to have enhancement (but as it doesn't affect many devices, it's 
a low priority for me).

For delays there is actually two delays :
One after call initiation : 5 seconds
And one after any action on the screen : 20 seconds.

If you have any idea on better values?
Should be values that also allow to dial dtmf to an attendant. So could be hard 
to find the ~good~ value. If I well remember, I took these values from android 
phone application. So, they have same timers for their dial locker. I don't 
know if they did studies about what should be more usable for users, but I'm 
disposed to change these values.

Besides I was wondering if I should not disable screen lock when on speaker 
mode (as it's done by default app). What do you think about that?

Original comment by r3gis...@gmail.com on 20 Sep 2010 at 8:53

GoogleCodeExporter commented 9 years ago
Based on my experience with dial-in long distance gateways you need to 
implement 3 delays (could be hard coded or user definable).

1. after call initiation : 3-5 seconds
2. inter-digit timeout (time to screen lock while a user enters dtmf) = 6 
seconds
3. screen timeout (after any other action on the screen) = 10 seconds

1 = fast screen lock after dialing out
2 = fast screen lock after navigating auto attendant
3 = moderate screen lock after any other action

When on speaker phone you probably don't need the screen lock but it won't hurt 
either. Use the #3 delay. 

Original comment by dcitele...@gmail.com on 21 Sep 2010 at 1:09