search

ouster-lidar / ouster-sdk

Ouster, Inc. sample code
Other
468 stars 440 forks source link

Increase client RECV_BUFF size to 1 MB #547

Closed ahuazuipiaoliang closed 1 year ago

ahuazuipiaoliang commented 1 year ago

Related Issues & PRs

https://github.com/ouster-lidar/ouster-ros/issues/190

Summary of Changes

increase buffer size

Validation

Tested with my LiDAR

Samahu commented 1 year ago

@ahuazuipiaoliang Thanks for submitting the PR, this is rather a known issue to us and increasing the RECV_BUFF size is needed. 1 MB seems to be the minimum value to resolve the issue. Since this involves the main the SDK and the ROS driver this involves some process to get it merged. Note that in order for this fix to work it also requires to increase network reception as I noted before: buffer https://github.com/ouster-lidar/ouster-ros/issues/190#issuecomment-1675273573. I will circle back with you on merging the fix soon.

ahuazuipiaoliang commented 1 year ago

@Samahu I've already modified the network reception but it didn't work, after modifying the RCVBUF_SIZE, it worked.

Samahu commented 1 year ago

I was trying to say that you need both things to be done, at least for some of the devices that I tested. You could verify that by resetting the size of network reception.

Samahu commented 1 year ago

Incorporated the changes into PR #548 to be able to edit before merge (since maintainers weren't given permission to edit the PR).