search

ouster-lidar / ouster-sdk

Ouster, Inc. sample code
Other
468 stars 440 forks source link

Fix required CMake version when CMAKE_CXX_COMPILER_LAUNCHER is defined #566

Closed tokoro10g closed 11 months ago

tokoro10g commented 12 months ago

This PR fixes minimum CMake version in CMakeLists.txt

tokoro10g commented 11 months ago

Related Issues & PRs

The issue is introduced by the version 20231031 0.10.0

Summary of Changes

This PR fixes minimum CMake version in CMakeLists.txt. CMAKE_CXX_COMPILER_LAUNCHER CMake variable is available from version 3.4 according to the official documentation: https://cmake.org/cmake/help/v3.4/variable/CMAKE_LANG_COMPILER_LAUNCHER.html#variable:CMAKE_%3CLANG%3E_COMPILER_LAUNCHER

Validation

Checked that the CMAKE_CXX_COMPILER_LAUNCHER variable is properly picked up by CMake older than 3.17. (Ubuntu 20.04, cmake 3.16.3)

@twslankard Hi, could you review this patch?

tokoro10g commented 11 months ago

@Samahu I updated the description of this PR to meet the requirements on CI. Could you rerun the check?

Samahu commented 11 months ago

@tokoro10g unfortunately GH or the script that checks PR description does not pick the changes, but nonetheless I went ahead and merged your proposed fix. Thanks for your contribution!