search

out-fox-it / aj-ty-spojka

Web application that connects programmers based on their experience, interests and the type of person they are looking for (mentor, buddy, mentee) through matching and contact sharing.
GNU General Public License v3.0
0 stars 0 forks source link

Fixed NavBar for mobile #48

Closed MartinaVilimova closed 3 years ago

MartinaVilimova commented 3 years ago

Transparency removed and navigation fixed at the bottom. The biggest problem was the hidden text behind the menu. I tried to solve the problem by creating a second wrapper, which got NavBar off the bar, but did not solve the hidden text! Then I copied the NavBar, but it was a lot of duplicate code. in the end I solved it by adjusting the height and moving the lower edge.

If you know of a better solution, suggestions are welcome.

agnes97 commented 3 years ago

I have a dumb question. :joy:

When I checkout from master to this branch, I can't access Profile, therefore I can never see where the bug happened.

Profile page doesn't have a Route in App index (where all the pages are required to be) and if I add it, I see old Profile page that's up to be refactored.

const Routes: React.FC = () => (
    <Switch>
        <Route path="/profile" component={Profile} /> // this needs to be added here
        <Route path="/register" component={Register} />
        <Route path="/" component={Home} />
    </Switch>
)
MartinaVilimova commented 3 years ago

No question is stupid 🙂

Well, if you are on a fix-navbar branch, you will not see the refactor located on another branch. While testing, I put a very long text on the page and tried.