search

outadoc / home-slide-android

Access your Home Assistant devices quickly from anywhere on your Android device
https://homeslide.app
Apache License 2.0
54 stars 8 forks source link

feat(setup): improve support for internal/external URLs #387

Closed outadoc closed 3 years ago

outadoc commented 3 years ago

Since a few versions back, Home Assistant supports setting internal and external instance URLs right from the interface. This is something we can make use of during setup!

Screenshot 2021-03-13 at 20 32 30

For the manual setup flow

Before this PR, we just used whatever the user typed in as the internal base URL. Now both URLs can be auto-configured using the discovery_info call we already make to check for a valid instance.

For better user feedback, it's now possible to click on the "continue" button when there has been an error, and it will display some diagnostics information to hopefully help solve the issue.

For the mDNS zero-conf flow

Before this PR, we used the discovered IP and port as the internal URL, and the base_url property given back as the remote URL. This property is now deprecated and replaced by the internal/external URL pair, which we now use and will improve reliability.

Closes #376

Closes #358 by improving reliability + adding a feedback popup

seanmccabe commented 3 years ago

Posted new comment on https://github.com/outadoc/home-slide-android/issues/358

I do not use seperate URLs for external and internal which appears to be the assumption here.

outadoc commented 3 years ago

This shouldn't be a problem, if you only have one URL it's the one that will be used.

seanmccabe commented 3 years ago

Ok, should take a look at my comment though as there is an issue with login and the error messages mentions the urls, but the java error seems to point to an issue it is having with the ssl cert.