search

outbrain / fwumious_wabbit

Fwumious Wabbit, fast on-line machine learning toolkit written in Rust
Other
133 stars 19 forks source link

Fibhash trick #123

Closed SkBlaz closed 9 months ago

SkBlaz commented 10 months ago

Seems to work, ripe for first reviews. Rationale here. Ignoring some tests for now fyi

SkBlaz commented 9 months ago

yes, and does bot offer consistently better results, so not merging

On Wed, 6 Dec 2023, 08:26 Yonatan Karni, @.***> wrote:

@.**** commented on this pull request.

I don't understand - this comes in addition to the FNV hash, it doesn't replace it?

— Reply to this email directly, view it on GitHub https://github.com/outbrain/fwumious_wabbit/pull/123#pullrequestreview-1766831277, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACMSERBJZKQUUZFTSBV3CL3YIAMZDAVCNFSM6AAAAAA7I543GKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONRWHAZTCMRXG4 . You are receiving this because you modified the open/close state.Message ID: @.***>

yonatankarni commented 9 months ago

but did you try using Fibonacci hashing instead of FNV hash?

On Wed, Dec 6, 2023 at 10:15 AM SkBlaz @.***> wrote:

yes, and does bot offer consistently better results, so not merging

On Wed, 6 Dec 2023, 08:26 Yonatan Karni, @.***> wrote:

@.**** commented on this pull request.

I don't understand - this comes in addition to the FNV hash, it doesn't replace it?

— Reply to this email directly, view it on GitHub < https://github.com/outbrain/fwumious_wabbit/pull/123#pullrequestreview-1766831277>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACMSERBJZKQUUZFTSBV3CL3YIAMZDAVCNFSM6AAAAAA7I543GKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONRWHAZTCMRXG4>

. You are receiving this because you modified the open/close state.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/outbrain/fwumious_wabbit/pull/123#issuecomment-1842387152, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZCJMI5ROD7AO6DPPZJ6OTYIASRHAVCNFSM6AAAAAA7I543GKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBSGM4DOMJVGI . You are receiving this because your review was requested.Message ID: @.***>

-- The above terms reflect a potential business arrangement, are provided  solely as a basis for further discussion, and are not intended to be and do  not constitute a legally binding obligation. No legally binding obligations will be created, implied, or inferred until an agreement in final form is  executed in writing by all parties involved.

This email and any attachments hereto may be confidential or privileged.  If you received this communication by mistake, please don't forward it to anyone else, please  erase all copies and attachments, and please let me know that it has gone  to the wrong person. Thanks.

SkBlaz commented 9 months ago

No, it's a replacement for the mod's biases, not whole hash. Alternative would be mm3 + this directly, that wasn't tested

On Wed, 6 Dec 2023, 09:44 Yonatan Karni, @.***> wrote:

but did you try using Fibonacci hashing instead of FNV hash?

On Wed, Dec 6, 2023 at 10:15 AM SkBlaz @.***> wrote:

yes, and does bot offer consistently better results, so not merging

On Wed, 6 Dec 2023, 08:26 Yonatan Karni, @.***> wrote:

@.**** commented on this pull request.

I don't understand - this comes in addition to the FNV hash, it doesn't replace it?

— Reply to this email directly, view it on GitHub <

https://github.com/outbrain/fwumious_wabbit/pull/123#pullrequestreview-1766831277>,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ACMSERBJZKQUUZFTSBV3CL3YIAMZDAVCNFSM6AAAAAA7I543GKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONRWHAZTCMRXG4>

. You are receiving this because you modified the open/close state.Message ID: @.***>

— Reply to this email directly, view it on GitHub < https://github.com/outbrain/fwumious_wabbit/pull/123#issuecomment-1842387152>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAZCJMI5ROD7AO6DPPZJ6OTYIASRHAVCNFSM6AAAAAA7I543GKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBSGM4DOMJVGI>

. You are receiving this because your review was requested.Message ID: @.***>

-- The above terms reflect a potential business arrangement, are provided solely as a basis for further discussion, and are not intended to be and do not constitute a legally binding obligation. No legally binding obligations will be created, implied, or inferred until an agreement in final form is executed in writing by all parties involved.

This email and any attachments hereto may be confidential or privileged. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. Thanks.

— Reply to this email directly, view it on GitHub https://github.com/outbrain/fwumious_wabbit/pull/123#issuecomment-1842438364, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACMSERGX4FL7U4BGJXOMZNDYIAV5HAVCNFSM6AAAAAA7I543GKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBSGQZTQMZWGQ . You are receiving this because you modified the open/close state.Message ID: @.***>

yonatankarni commented 9 months ago

yes, I don't mean a replacement for mmh3 - but for feature combinations we use FNV hash so we could replace that as well. but it's probably negligible compared to mmh3 anyway...

On Wed, Dec 6, 2023 at 11:57 AM SkBlaz @.***> wrote:

No, it's a replacement for the mod's biases, not whole hash. Alternative would be mm3 + this directly, that wasn't tested

On Wed, 6 Dec 2023, 09:44 Yonatan Karni, @.***> wrote:

but did you try using Fibonacci hashing instead of FNV hash?

On Wed, Dec 6, 2023 at 10:15 AM SkBlaz @.***> wrote:

yes, and does bot offer consistently better results, so not merging

On Wed, 6 Dec 2023, 08:26 Yonatan Karni, @.***> wrote:

@.**** commented on this pull request.

I don't understand - this comes in addition to the FNV hash, it doesn't replace it?

— Reply to this email directly, view it on GitHub <

https://github.com/outbrain/fwumious_wabbit/pull/123#pullrequestreview-1766831277>,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ACMSERBJZKQUUZFTSBV3CL3YIAMZDAVCNFSM6AAAAAA7I543GKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONRWHAZTCMRXG4>

. You are receiving this because you modified the open/close state.Message ID: @.***>

— Reply to this email directly, view it on GitHub <

https://github.com/outbrain/fwumious_wabbit/pull/123#issuecomment-1842387152>,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAZCJMI5ROD7AO6DPPZJ6OTYIASRHAVCNFSM6AAAAAA7I543GKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBSGM4DOMJVGI>

. You are receiving this because your review was requested.Message ID: @.***>

-- The above terms reflect a potential business arrangement, are provided solely as a basis for further discussion, and are not intended to be and do not constitute a legally binding obligation. No legally binding obligations will be created, implied, or inferred until an agreement in final form is executed in writing by all parties involved.

This email and any attachments hereto may be confidential or privileged. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. Thanks.

— Reply to this email directly, view it on GitHub < https://github.com/outbrain/fwumious_wabbit/pull/123#issuecomment-1842438364>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACMSERGX4FL7U4BGJXOMZNDYIAV5HAVCNFSM6AAAAAA7I543GKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBSGQZTQMZWGQ>

. You are receiving this because you modified the open/close state.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/outbrain/fwumious_wabbit/pull/123#issuecomment-1842553362, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZCJMLQPBNKFJGGPDBWELTYIA6RBAVCNFSM6AAAAAA7I543GKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBSGU2TGMZWGI . You are receiving this because your review was requested.Message ID: @.***>

-- The above terms reflect a potential business arrangement, are provided  solely as a basis for further discussion, and are not intended to be and do  not constitute a legally binding obligation. No legally binding obligations will be created, implied, or inferred until an agreement in final form is  executed in writing by all parties involved.

This email and any attachments hereto may be confidential or privileged.  If you received this communication by mistake, please don't forward it to anyone else, please  erase all copies and attachments, and please let me know that it has gone  to the wrong person. Thanks.