FFM blocks simplified (stepping stone for caching & SIMD)

outbrain / fwumious_wabbit

Fwumious Wabbit, fast on-line machine learning toolkit written in Rust

Other

133 stars 19 forks source link

FFM blocks simplified (stepping stone for caching & SIMD) #96

Closed ggaspersic closed 1 year ago

ggaspersic commented 1 year ago

Overview:

removal of unused (old) related functionality
replacing weights: Vec<WeightAndOptimizerData>, with 2 separate vectors (this will allow us later on to have easier SIMD & caching (when doing forward pass)). The impact of this is that the reading also needed to be changed.
removed the redundant usage of macros
updated variable names to make them more descriptive

SkBlaz commented 1 year ago

General: Changing weight structure might (or might not) have implications for reading speed/some intermediary operations; assuming this is negligible speed wise? (there could be a mini test/benchmark just so we're sure, even though it's most likely not an issue)