outbreak-info / outbreak.info-resources

A curated repository of metadata of resources on COVID-19 and SARS-CoV-2
MIT License
0 stars 4 forks source link

[DDE GUIDE ISSUE] Saving and resetting form #125

Open gtsueng opened 4 years ago

gtsueng commented 4 years ago

The form autosaves, which seems to be a potential source of error that may affect the integrity of the data. Allowing a manual trigger to save may help.

Reset issue that may cause data integrity problems:

  1. After entering a sample metadata and getting as far as the 'submit' screen, clicked on the 'start over' button. Got the warning sign that this action can't be reverted
  2. Start over, doesn't actually clear the form, so user must manually remove/replace items
  3. If user removes something, it doesn't necessarily disappear from the saved json
  4. User can get to submission page (and even submit, IF not for the funder name issue) with mismatching data.

Funder manually removed as seen here: should not have funding

But, when I checked the json after clicking 'submit' (fortunately, submission doesn't work), the funder previous was still saved in the json. guide preview

flaneuse commented 4 years ago

A few additional notes:

flaneuse commented 4 years ago

Clicking "back" after successfully registering a dataset also doesn't clear the form... and refreshing the page means the most recently registered dataset remains #zombiedata @marcodarko.