flaneuse
commented
1 year ago @olekkorob: a few changes (sorry, I forgot to add these to the GH issue)
-
on /regions, add a loading spinner when you change the select box on the top and bottom plots (example: change from "Daily worldwide COVID-19 cases" to "deaths")
-
571 looks good, but it would be good to change the
xminandxmaxparameter in the route, so that 1) the routes can be shared; 2) the plots below also update.- Relatedly, if you zoom in manually on the plot right now, the edges of the stream graph are funky since you're not recomputing the stream. For performance, this might be most easily solved with an SVG clipping mask. Let me know if you want to discuss further
- Relatedly, if you zoom in manually on the plot right now, the edges of the stream graph are funky since you're not recomputing the stream. For performance, this might be most easily solved with an SVG clipping mask. Let me know if you want to discuss further
- Eventually, for performance, these will be recomputed via an API call rather than fetching all the data at once and then filtering (e.g. by default, only request/plot the latest 6 months; if you select all time, that would generate a new API call with different parameters).
- I forgot to mention it in the issue, but the two longitudinal plots lower on the page should also have the same buttons/functionality (show 6 months of data by default, allow to change to other dates
- Can you check the date calculation, that it's actually doing a 6 month window? If I run
getBeforeDate(new Date("2022-10-31 23:00"), 1), I get 30 days before, not one month before. I would suggest using d3-time to calculate the interval, since it's already set up to deal with the messiness of dates in JavaScript and handle things like leap years.- On #573, there's some weirdness with the bars resizing when you view all lineages. I'm not sure which calculation/axis is correct. (example: http://localhost:8080/situation-reports/bq.1*%20%5Bomicron%20(bq.1.x)%5D?loc&selected)
top 10: the width of the BQ.1.1 bar = 163.8670177466658 px. When you switch to all lineages, it changes to 143.2341603981887 px.
561, #562, #567, #571, #572, #573