search

outcaste-io / issues

File issues here across all public Outcaste Repositories
Apache License 2.0
6 stars 0 forks source link

When build with -buildmode=plugin, go complains about an asm error #22

Closed siddharthlatest closed 2 years ago

siddharthlatest commented 2 years ago

Any go package that depends on Badger and builds using buildmode=plugin or anything using dynamic link will see the error:

when dynamic linking, R15 is clobbered by a global variable access and is used here To reproduce this, try the following:

git clone https://github.com/appbaseio/reactivesearch-api make clean && make ^ The above project uses buildmode=plugin to build and badger is a dependency of it.

This is originating from cespare/xxhash module, the issue is described over here: cespare/xxhash#54 4. It’s fixed in their latest release: v2.1.2. Updating this module to this release in badger should resolve this issue. There is also a PR in the original repo that contains the fix: https://github.com/dgraph-io/badger/pull/1777.

Further reference is here: github.com/golang/go/issues/43661.

Originally raised at: https://discuss.dgraph.io/t/when-build-with-buildmode-plugin-go-complains-about-an-asm-error/16341

manishrjain commented 2 years ago

Hey @siddharthlatest , would you like to send a PR?

eh-steve commented 2 years ago

Hi Manish, would you like me to open the badger PR here instead?

manishrjain commented 2 years ago

Yeah, that'd be great.

eh-steve commented 2 years ago

https://github.com/outcaste-io/badger/pull/7

manishrjain commented 2 years ago

This PR was merged.