search

outcomesinsights / conceptql

A high-level language that allows researchers to unambiguously define their research algorithms.
MIT License
17 stars 6 forks source link

Rework Casting #76

Closed aguynamedryan closed 4 years ago

aguynamedryan commented 7 years ago

Casting may not even make sense under OI CDM. I've long believed that if an algorithm contains a casting operator, it implies that ConceptQL is missing some more useful and appropriate operator. E.g. We made the PlaceOfServiceFilter operator to avoid casting conditions/procedures into visits to intersect them with ConditionType

Perhaps it is time to retire casting. If not, we'll have to revisit this ticket and devise a sensible casting matrix as we did for OMOP

markdanese commented 7 years ago

In the OI CDM paper, we identify the fact that most data models use the visit as a way to connect pieces of information together. We have formalized that idea as "contexts" in OI CDM. To some degree collections might be involved in connecting pieces of information when the connection is broader (at the visit or claim level). I would imagine that most casting would be referring to a shared context or possibly shared collection.

aguynamedryan commented 7 years ago

@markdanese, is what you're talking about related to outcomesinsights/jigsaw#375

I'd like to review how we're using casting operators and what we can do to avoid their use and simplify the algorithms that currently employ them.

jenniferduryea commented 7 years ago

We go into a lot more detail about these in outcomesinsights/jigsaw#379 . @aguynamedryan do you still need more clarification?

aguynamedryan commented 7 years ago

@markdanese, @jenniferduryea, have we decided to remove casting operators?

jenniferduryea commented 7 years ago

I believe #142 has made casting operators optional. I'm ok with removing them.

markdanese commented 7 years ago

Sure. Good for me too. Do we need to migrate any of Amgen's algorithms?

jenniferduryea commented 7 years ago

Yes we do. Let's create a new ticket with a list of casting operators we are going to remove and then we can search for all existing algorithms. I can then coordinate with Fangfei about how to go about doing this.

jenniferduryea commented 6 years ago

move this to chisel since this is not necessary for broom.

aguynamedryan commented 5 years ago

Implementing #92 would make searching for casting operators much easier.

needs #92

aguynamedryan commented 4 years ago

Casting has been removed from ConceptQL as it is no longer required.