outcomesinsights / generalized_data_model

Outcomes Insights' Data Model for Clinical Research
MIT License
16 stars 3 forks source link

Consider changing type_concept_id to prov_type_concept_id #83

Closed marc-outins closed 7 years ago

marc-outins commented 7 years ago

Currently in the column type_concept_id exists in tables contexts, clinical_codes, and admission_details. The column name is not very descriptive about what goes in there. For the most part this column describes the provenance of the record and so we should consider changing to prov_type_concept_id or something like that.

aguynamedryan commented 7 years ago

I'd rather just call it provenance_concept_id

markdanese commented 7 years ago

agree. provenance_concept_id

markdanese commented 7 years ago

will create fresh issues based on discussion today