search

outdoorbits / little-backup-box

This software turns a single-board computer into a versatile, pocket-sized backup solution. Especially for digital photography, this is the solution for backing up images and media files on mass storage devices when traveling or at events. Media content can be viewed and rated for the subsequent process.
http://littlebackupbox.com
GNU General Public License v3.0
504 stars 103 forks source link

new lib_mail.sh #83

Closed outdoorbits closed 3 years ago

outdoorbits commented 3 years ago

Mails are sent by function send_email in lib-mail.sh. The function send_email takes up to three arguments: subject, plain-text, html-text If in config.cfg enabled, ip.sh sends a HTML-Link.

outdoorbits commented 3 years ago

Hi,

I saved it as draft. It's not tested outside of ip.sh.

I will rework it later and integrate your changes.

Thank you, Stefan

Am 9. Juli 2021 08:45:59 MESZ schrieb Dmitri Popov @.>: @. commented on this pull request.

Thank you very much for another great pull request! I only have two minor points.

+STORAGE_MOUNT_POINT="/media/storage" # Mount point of the storage device +SOURCE_DEV="sdb1" # Name of the source device +SOURCE_MOUNT_POINT="/media/source" # Mount point of the source device +POWER_OFF=true # Set to false to disable automatic power off after backup +LOG=false # Set to true to enable logging +NOTIFY=false # Set to true to enable email notifications +# Mail settings (specify to receive notifications) +# If the mail settings are specified, Little Backup Box +# sends an email with the device's IP address even when +# $NOTIFY is set to false +SMTP_SERVER="" +SMTP_PORT="" +MAIL_USER="" +MAIL_PASSWORD="" +MAIL_TO="" +MAIL_HTML="true" # Set to false to disable HTML-Mails

I think that there is no need for double quotes: MAIL_HTML=true is correct

  • Arguments

  • SUBJECT=$1
  • TEXT_PLAIN=$2
  • TEXT_HTML=$3

  • Config

  • CONFIG_DIR=$(dirname "$0")
  • CONFIG="${CONFIG_DIR}/config.cfg"
  • dos2unix "$CONFIG"
  • source "$CONFIG"
  • BOUNDARY="${RANDOM}${RANDOM}${RANDOM}"
  • TEXT=""

  • Mail-body

  • if [ "${MAIL_HTML}" = "true" ];

Same here: if [ "${MAIL_HTML}" = true ];

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/dmpop/little-backup-box/pull/83#pullrequestreview-702729446

-- Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.