Closed olivermeyer closed 2 years ago
@oavdeev tagging you for visibility : )
can we make it off by default so its backwards compatible? it seems like right now if someone upgrades their deployment using this template, they'll have instance metadata disabled and their metaflow tasks will stop working
For some reason I thought the TF default for http_endpoint
was disabled
but it's actually enabled
- just fixed it. All three variables now default to the TF default so upgrading without overriding them should have no impact.
Hi @oavdeev, is there anything I can do to help release this? We're currently running Metaflow off my fork and that's not nice
Sorry for the delay! I'll cut a release next week
@oavdeev bumping this again :)
Would it make sense to add something like https://github.com/cycjimmy/semantic-release-action to the repo so that releases are cut automatically after merging?
Hey @olivermeyer sorry for the delay, @ob-uk just cut a new release 0.8.0! As for the github action, I think its a good idea eventually but for now we don't have enough automated testing to be cutting releases completely on auto-pilot. Today we do at least some manual testing for each release to make sure it works as expected.
Hey @olivermeyer sorry for the delay, @ob-uk just cut a new release 0.8.0! As for the github action, I think its a good idea eventually but for now we don't have enough automated testing to be cutting releases completely on auto-pilot. Today we do at least some manual testing for each release to make sure it works as expected.
Awesome thanks! And makes sense about testing.
This PR adds support for IMDSv2 to the compute EC2 launch template. See the doc for metadata options for more info.