outerbounds / terraform-aws-metaflow

Deploy production-grade Metaflow cloud infrastructure on AWS
https://registry.terraform.io/modules/outerbounds/metaflow/aws/latest
Apache License 2.0
58 stars 50 forks source link

Update docs and remove the default for with_public_ip #49

Closed oavdeev closed 1 year ago

oavdeev commented 1 year ago

The reasonable default value for this flag depends on whether subnets are public or not, so its arguably better to make users set it explicitly.

https://github.com/outerbounds/terraform-aws-metaflow/pull/42#issuecomment-1329980605