search

outerbounds / terraform-aws-metaflow

Deploy production-grade Metaflow cloud infrastructure on AWS
https://registry.terraform.io/modules/outerbounds/metaflow/aws/latest
Apache License 2.0
56 stars 48 forks source link

Need additional parameter for RDS security group #89

Open cstano-attn opened 6 months ago

cstano-attn commented 6 months ago

For teams leveraging the module, there's currently no way to pass in additional CIDRs to the created RDS security group for things like VPN access for maintenance, handling migrations of metaflow services to kubernetes clusters without redeploying / importing the RDS, etc.

The current way to do this is to define an aws security group rule and attach it to the RDS security group, however a TF bug creates a scenario where this rule requires a double apply (first apply attaches, second apply detaches, third apply re-attaches). This creates intermittent issues for anything that is not the metaflow metadata service trying to connect to the RDS backend.

cstano-attn commented 6 months ago

Opened up this PR to address https://github.com/outerbounds/terraform-aws-metaflow/pull/90