search

outeredge / magento-structured-data-module

Magento Structured Data Module by outer/edge
MIT License
47 stars 13 forks source link

Fix Product and Contact schema only being appended when CMS enabled #28

Closed sweetappleuk closed 2 years ago

sweetappleuk commented 2 years ago

Add top level ON/OFF option for appending Schema, replace incorrect ifconfig="structureddata/cms/enable" dependancy

davidwindell commented 2 years ago

Nice spot, we've removed the top-level flag as the module should just be disabled instead.

sweetappleuk commented 1 year ago

Cleaner to not add OuterEdge\StructuredData\Block\Jsonld if it's not needed. Also quicker to have a rapid ON/OFF switch rather than having to disable 3 different options and then forgetting which one's you previously had enabled...

Yours

Clive Sweeting

Sweet-Apple develops fast, search engine friendly websites with no fuss, no bother, on time and on budget.

T: 01380 830224 M: 0777 6075050 * E: @.*** W: http://www.sweet-apple.co.uk

Skype: ceesweet Messages: @.*** Google: https://g.page/sweet-apple-co-uk

Happy with my work? Leave a review for us: https://g.page/r/CauEn3UiSskLEAg/review

On 16 Aug 2022, at 11:43, David Windell @.***> wrote:

Nice spot, we've removed the top-level flag as the module should just be disabled instead.

— Reply to this email directly, view it on GitHub https://github.com/outeredge/magento-structured-data-module/pull/28#issuecomment-1216467620, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF7HJA7UCIYFVLRMR3AP3DVZNWGLANCNFSM56UZXYUQ. You are receiving this because you authored the thread.