search

outeredge / magento-structured-data-module

Magento Structured Data Module by outer/edge
MIT License
52 stars 14 forks source link

[4.2.1] Incompatibility between version code and composer.json #80

Open bhennesAdv opened 3 months ago

bhennesAdv commented 3 months ago

Hello,

I just tried to install your module with composer on a magento 2.4.2 (PHP version 7.4)

The version choosen by composer is the version 4.2.1 because it still is compatible with the PHP version according to the composer.json file declaration.

Still the module does not compile under those conditions for the following reasons :

Not sure if this is usefull as the release is already out and I doubt that a correction for 2.4.2 is planned. I'll still use your code as a base and try to make it work under my conditions (Maybe submit a PR here for a "4.2.2" version if the code quality is OK)

Hopefully you can change the composer.json of the 4.2.1 to avoid missinstallation to other people.

Regards,

davidwindell commented 3 months ago

Hi @bhennesAdv

Thanks for the report, it might be worth trying v4.0.10 which doesn't include the API.

If that works for you please let us know and we'll update the 4.1/4.2 releases to be PHP 8 only.

bhennesAdv commented 3 months ago

Hi,

v4.0.10 works for PHP7.4 but unfortunately the 2nd reasons still exists for me (Due to my magento version). Magento\Theme\ViewModel\Block\Html\Header\LogoPathResolver being non existent.

It might be worth adding a dependency to the composer.json like : magento/module-theme : ">=101.1.5"

I'm not sure about the version where the LogoPathResolver was added.

Regards,