search

outfoxx / swiftpoet

Kotlin and Java API for generating .swift source files.
Apache License 2.0
284 stars 27 forks source link

SwiftPoet Status #87

Closed oldergod closed 9 months ago

oldergod commented 12 months ago

Hello!

At Wire https://github.com/square/wire we rely heavily on SwiftPoet and we’re a bit anxious about the project’s state and its future. Would you be open to add one or two of us to it so we can make changes, fix bugs, and make some releases? Is SwiftPoet still getting support from you or someone else? Worst case scenario for us would be to fork the project. We'd love to hear back from you; we're totally up to helping the project is possible. Let us know

kdubb commented 12 months ago

Absolutely! Would love the help!

dnkoutso commented 12 months ago

@kdubb would love to start with this https://github.com/outfoxx/swiftpoet/pull/86

also we identified more issues that are probably fixed in Kotlin Poet....seems like a large update required...I could give it a shot but was hoping for some help as well.

kdubb commented 12 months ago

The biggest issue holding things back is when I switched to SonarCloud originally I didn't realize the issues with external PR's.

kdubb commented 12 months ago

I have fixed workflows I can adapt from our other repositories.

dnkoutso commented 11 months ago

Thank you @kdubb ! We had identified another issue and we had fixed it at the Wire level...its possible this can be fixed to SwiftPoet as it seems some new logic was added into KotlinPoet to deal with this.

https://github.com/square/wire/pull/2658

In particular I think we are missing logic like this https://github.com/square/kotlinpoet/blob/main/kotlinpoet/src/main/java/com/squareup/kotlinpoet/CodeWriter.kt#L432 within CodeWriter.kt...

It turns out in some cases if we can resolve the type name we do not store that as an import to keep for the second pass to actually write the correct imports...

I have started trying to accomplish that in SwiftPoet and the Wire PR above has a test case that verifies the issue...

kdubb commented 11 months ago

@dnkoutso I'm unsure of exactly what you are wanting. Can you make a PR? Or at least a PR with a failing test case?

kdubb commented 11 months ago

@oldergod Who should be added to the team?

oldergod commented 11 months ago

@dnkoutso and myself @oldergod would be great! Thank you

kdubb commented 11 months ago

@oldergod I've invited you both to the team! Welcome! I'm happy to have help maintaining and updating the library!

I would only ask that you guys keep me in the loop via review requests as we begin working together.

oldergod commented 11 months ago

I would only ask that you guys keep me in the loop via review requests as we begin working together.

Of course!

oldergod commented 10 months ago

@kdubb Hey Kevin, we cannot merge PRs for we're not authorised to do so.

image

Did you mean to keep reviewing things and merging them yourself?

kdubb commented 10 months ago

@oldergod Nope, I thought you were able to do so.

dnkoutso commented 9 months ago

I think we should close this?

oldergod commented 9 months ago

🚀