Including sub types within external extensions do not emit imports

[dnkoutso]

Given test:

@Test
  @DisplayName("Generates correct imports for extension types ")
  fun testParentExtensionBug() {
    val parentElement = typeName(".Parent")
    val obsElement = typeName("RxSwift.Observable.Element")

    val extension =
      ExtensionSpec.builder(parentElement) // <----- using parentElement vs obsElement.enclosingTypeName()!! fails.
        .addFunction(
          FunctionSpec.builder("test")
            .returns(obsElement)
            .build()
        )
        .build()

    val testFile = FileSpec.builder("Test", "Test")
      .addExtension(extension)
      .build()

    val out = StringWriter()
    testFile.writeTo(out)

    assertThat(
      out.toString(),
      equalTo(
        """
            import RxSwift // <------ this is missing but should be there.

            extension Parent {

              func test() -> RxSwift.Observable.Element { // <---- this looks right if its fully qualified imo?
              }

            }

        """.trimIndent()
      )
    )
  }

Branch: https://github.com/outfoxx/swiftpoet/compare/extension_import_bug?expand=1

Seems related to https://github.com/outfoxx/swiftpoet/pull/55

It seems when using obsElement as the extension type imports are emitted correctly which is why the test that was added in #55 passes correctly.

When removing:

if (typeSpec is ExternalTypeSpec) {
  return stackTypeName(i, simpleName)
}

Things start working, perhaps this is meant to check an additional condition? I am still getting familiarized with this code @kdubb

cc @lickel

[dnkoutso]

@kdubb any ideas would be greatly appreciated, or hints...

[dnkoutso]

Seems somehow that resolve returns back a type in the failing test.

Notice resolved came back as Parent.Element

In the passing test case this does not resolve to anything which then calls importableType(typeName) and adds the import to the suggested import types...

[kdubb]

@dnkoutso I'll have a look at this tonight

[dnkoutso]

Thanks @kdubb !

[dnkoutso]

@kdubb sorry for the additional ping, was hoping for any guidance on this. Currently it can cause an error in Wire output with a missing import.

Thanks again and apologies

[dnkoutso]

Would love an update here as this is currently blocking us.