outfoxxed / hy3

Hyprland plugin for an i3 / sway like manual tiling layout
GNU General Public License v3.0
391 stars 32 forks source link

Build failure for new Hyprland versions #102

Closed SoulHarsh007 closed 2 months ago

SoulHarsh007 commented 2 months ago

:wave: Hello, the build for hy3 fails with the following errors:

 -> cd /tmp/hyprpm/update && PKG_CONFIG_PATH="/home/soulharsh007/.local/share/hyprpm/headersRoot/share/pkgconfig" cmake --build build
[ 14%] Building CXX object CMakeFiles/hy3.dir/src/main.cpp.o
In file included from /usr/include/c++/13.2.1/memory:78,
                 from /home/soulharsh007/.local/share/hyprpm/headersRoot/include/hyprland/src/Compositor.hpp:3,
                 from /tmp/hyprpm/update/src/main.cpp:1:
/usr/include/c++/13.2.1/bits/unique_ptr.h: In instantiation of ‘constexpr std::__detail::__unique_ptr_t<_Tp> std::make_unique(_Args&& ...) [with _Tp = Hy3Layout; _Args = {}; __detail::__unique_ptr_t<_Tp> = __detail::__unique_ptr_t<Hy3Layout>]’:
/tmp/hyprpm/update/src/main.cpp:76:1:   required from here
/usr/include/c++/13.2.1/bits/unique_ptr.h:1070:30: error: invalid new-expression of abstract class type ‘Hy3Layout’
 1070 |     { return unique_ptr<_Tp>(new _Tp(std::forward<_Args>(__args)...)); }
      |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /tmp/hyprpm/update/src/globals.hpp:9,
                 from /tmp/hyprpm/update/src/main.cpp:7:
/tmp/hyprpm/update/src/Hy3Layout.hpp:71:7: note:   because the following virtual functions are pure within ‘Hy3Layout’:
   71 | class Hy3Layout: public IHyprLayout {
      |       ^~~~~~~~~
In file included from /home/soulharsh007/.local/share/hyprpm/headersRoot/include/hyprland/src/managers/../layout/DwindleLayout.hpp:3,
                 from /home/soulharsh007/.local/share/hyprpm/headersRoot/include/hyprland/src/managers/LayoutManager.hpp:3,
                 from /home/soulharsh007/.local/share/hyprpm/headersRoot/include/hyprland/src/Compositor.hpp:14:
/home/soulharsh007/.local/share/hyprpm/headersRoot/include/hyprland/src/managers/../layout/IHyprLayout.hpp:139:18: note:     ‘virtual void IHyprLayout::moveWindowTo(CWindow*, const std::string&, bool)’
  139 |     virtual void moveWindowTo(CWindow*, const std::string& direction, bool silent = false) = 0;
      |                  ^~~~~~~~~~~~
make[2]: *** [CMakeFiles/hy3.dir/build.make:76: CMakeFiles/hy3.dir/src/main.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/hy3.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

Full build log: https://paste.soulharsh007.dev/p/02ea733.log

Hyprland version:

❯  hyprctl version
Hyprland, built from branch main at commit 82222342f10a7eff0ec9be972153e740d0f95213 dirty (shaders: Use sin-less hash for noise (5607)).
Date: Wed Apr 17 23:31:50 2024
Tag: v0.39.1-4-g82222342, commits: 4464

flags: (if any)
halperyon commented 2 months ago

got same problem on the git version of hyprland, maybe it's just the prerelease breaking things?

try reverting to a stable version

Xrayya commented 2 months ago

I'm still having the same issue even after updating hyprland and hy3. Has anyone experienced the same problem?