search

outfoxxed / hy3

Hyprland plugin for an i3 / sway like manual tiling layout
GNU General Public License v3.0
391 stars 32 forks source link

Fix tab bar visual defects when switching workspaces #115

Closed SimonBrandner closed 3 weeks ago

SimonBrandner commented 1 month ago

Fixes https://github.com/outfoxxed/hy3/issues/100

The current solution is very hack and needs to be improved

outfoxxed commented 4 weeks ago

I'm not seeing any improvement with this

https://github.com/outfoxxed/hy3/assets/83010835/81bc811d-e878-41cd-9a82-bc5a9242a451

https://github.com/outfoxxed/hy3/assets/83010835/598097a7-f8ea-42db-9615-d49ecda98a60

SimonBrandner commented 3 weeks ago

The reason it doesn't work for you is scaling, however weird that sounds - no idea why yet...

SimonBrandner commented 3 weeks ago

@outfoxxed, I have updated the PR with the best solution I can currently think of - let me know if it is acceptable...

SimonBrandner commented 3 weeks ago

@outfoxxed, I think the current version should hopefully cover all the issues. The fix is quite simple, not exactly happy it took me so much time to get it done... :sweat_smile:

outfoxxed commented 3 weeks ago

Looks good to me but it appears master is behaving weirdly. Going to give upstream a day or a few and see if that fixes itself, if not fix whatever's segfaulting there, then merge this.

SimonBrandner commented 3 weeks ago

I am not seeing any segfaults myself though I haven't updated upstream in a while, let me know if you have any updates

outfoxxed commented 3 weeks ago

Missed something in my last fix against upstream and didn't test it. That's dealt with now and it seems to work.

SimonBrandner commented 3 weeks ago

Awesome - thanks!