outfoxxed / hy3

Hyprland plugin for an i3 / sway like manual tiling layout
GNU General Public License v3.0
533 stars 47 forks source link

Screensharing issue #69

Open aacebedo opened 9 months ago

aacebedo commented 9 months ago

Hi,

I am not 100% sure yet, but I think that hy3 causes a problem with screensharing of tabbed windows and hyprland portal.

If I try to share a non-focused tabbed window using https://mozilla.github.io/webrtc-landing/gum_test.html, I end up with a blank screen. This does not happen if the window is visible when I start sharing, but it freezes if I tab the window that is currently shared.

I am using hyprland, hy3 0.34 and xdg-desktop-portal-hyprland 1.3.1 on NixOS.

Anyone can reproduce?

Mange commented 9 months ago

Seems to be the same effect for me.

Note that window sharing always fails for me except for the first share after a Portal restart, so my reproduction was basically this:

  1. Restart portal
  2. Try to share window $window.
  3. Wait for preview to come up in my browser.
Case Outcome
Visible non-tabbed window Works
Visible tabbed window Works after some time, most of the times
Tabbed window that is not focused No preview response, not even black screen
> hyprctl version
Hyprland, built from branch  at commit 4f804d5f962070c531dea5025e61be8a0da8129e  ().
Date: 2024-01-31

# plugin=/nix/store/xp15haqh2pkwa48p187mncdqq5108cw3-hy3-0.1/lib/libhy3.so
outfoxxed commented 9 months ago

So what happens if you do the same thing on a normal hyprland group? We do roughly the same thing in hy3 that hyprland does with hidden windows in a group.

aacebedo commented 9 months ago

So what happens if you do the same thing on a normal hyprland group? We do roughly the same thing in hy3 that hyprland does with hidden windows in a group.

Tried grouped window, and it seems to have the same problem. So it may be related to hyprland. I opened a bug here https://github.com/hyprwm/xdg-desktop-portal-hyprland/issues/179. Depending on the response, I'll close this one.

outfoxxed commented 9 months ago

Alright let me know if its not just a hyprland issue