search

outfoxxed / hy3

Hyprland plugin for an i3 / sway like manual tiling layout
GNU General Public License v3.0
391 stars 32 forks source link

Compilation failure against Hyprland main: Two days ago CConfigManager::getWorkspaceRuleFor was removed and replaced wit CConfigManager::getWorkspaceRulesFor which returns a Vector of rules #94

Closed talpadk closed 2 months ago

talpadk commented 3 months ago

While compiling using pyprpm i noticed that "getWorkspaceRuleFor" was been removed in favor of getting a Vector of rules

This change was introduced in the commit titled: core: match all workspace rules instead of the first one only (https://github.com/hyprwm/Hyprland/pull/5340) aka https://github.com/hyprwm/Hyprland/commit/5e8c25d498ed5cb7852ae74a876b0c138a62d59d

Removing support for getting just a single workspace rule.

This was with Hyprland: commit 416b3d6167a996c7e94bd537cec20a12a0784efa (HEAD -> main, origin/main, origin/HEAD) Author: Vaxry vaxry@vaxry.net Date: Mon Apr 1 03:54:05 2024 +0100

This causes the compilation to fail on /src/Hy3Layout.cpp:1479:55: error: ‘class CConfigManager’ has no member named ‘getWorkspaceRuleFor’; did you mean ‘getWorkspaceRulesFor’? 1479 | const auto workspace_rule = g_pConfigManager->getWorkspaceRuleFor(workspace); | ^~~~~~~ | getWorkspaceRulesFor