search

outfrost / deckswipe

Single player card game skeleton based on Reigns and Lapse
MIT License
75 stars 29 forks source link

Switch to new Unity input system #43

Open BelchingJalapeno opened 3 years ago

BelchingJalapeno commented 3 years ago

This uses the 1.1.0-preview.1 of the new Input System instead of 1.0.0 due to a bug that was causing input to be lost when resuming on android after the back button was pressed. This still uses the event system for input on cards and uses a unity event for handling the escape key/quit action that is set in the editor on the Game Controller prefab in the Player Input component. This could be changed to a c# event and configured from code if you would prefer that over the unity events.

I also removed an invisible character U+FEFF near the start of the GoogleSheetsCollection file.

outfrost commented 3 years ago

Thank you for the contribution! I will review it soon when I find a moment.

The U+FEFF BYTE ORDER MARK is present in around half of the C# source files. It's redundant for UTF-8, and acts only as a magic number for the encoding, but C# standards theoretically mandated its use a while ago. Not sure if they do any more. I don't mind its removal, but it's also not very important :)

BelchingJalapeno commented 3 years ago

I looked for that character in a few other files after I found it but didn't find any at the time. I do see a few other files with that character now that I looked again. I just thought it was odd that it was in the middle of the using statements. Sorry about that.