outfrost / ld49

Coffee Crisis - a Ludum Dare 49 game
https://ldjam.com/events/ludum-dare/49/coffee-crisis
0 stars 0 forks source link

Tray breaks when barista sends it before placing cup down #46

Closed outfrost closed 2 years ago

outfrost commented 3 years ago

"Send it" command queues up on the tray before cup is placed down?

666Savior commented 3 years ago

Seems to be something with the is_handsEmpty() method on the player character. Tray checks for this to be empty before sending. It might not be properly updating while transitioning quickly from picking coffee to moving to the tray and clicking the tray before movement is complete? There is a possibility that my changes to the tray empty check fixed this but not confirmed.

outfrost commented 3 years ago

I think it happens because when you queue up an interaction with the serving tray before the barista is holding a cup, the code sees their hands are empty and queues up calling the customer, which doesn't make sense any more once the barista gets there.

It's one of the reasons I'd like to revisit whether we still want to queue up interactions (and how far we want the queue to go).

L1Q commented 3 years ago

The entire queue system is broken like that. I'm thinking either check for conditions again when it's time to pop an item from the queue or drop the whole queue concept completely - it doesn't seem to fit the pacing anyway.

666Savior commented 2 years ago

Should be fixed with change to clicking customer to call for order