outintech / nbjc-webapp

7 stars 2 forks source link

Add placeholder photo with spaces that has no photo #47

Open sereigh opened 3 years ago

sereigh commented 3 years ago

Issue #44

Spaces with no imageUrl now appear with a default image in search results.
Spaces with no imageUrl now appear with a default image on their details page.

Added existing 404 no-text image to the repository for use as the default image. Added conditional style to default image on the details page to prevent it from overflowing the media container.

QA Links:

Details Page Search Results

sereigh commented 3 years ago

Still open to review on implementation, but holding on a merge. The design team is currently creating a default image to be used.

sereigh commented 3 years ago

Hey @sereigh, implementation of the || operator here makes sense. Noted on the merge hold, did the design team give you an eta? If their timeline is unclear it might be ok to merge and then just change out the /web-no-image.png once they pass along the new asset. Either way looks good, thanks for getting this done!

No ETA just yet, I think they meet this week. Thank you for the feedback also!