Closed ApplePieAngel closed 1 year ago
As an update, I've updated all the Buttons to NavLinks. I've also added underlines under external links as I felt it wasn't clear to users if they were links previously.
As another update, I know several months ago we talked about not liking how testing was currently done. I've done a lot of research (books, conference talks, articles, etc) and added unit tests for this PR as my recommendation and my proposal for how unit tests should look like going forward.
Edit: (12/30/2022): I'd love to abstract a lot of these tests as E2E tests, they might be better suited in Cypress or Playright.
Merge notes: Will need to be merged with #73 at least. (Can ignore AppBar)
Description
The purpose of this change is to update the footer component to align with the new design created by the design team.
Reasons for changes:
The reasoning behind my test cases styling is inspired from "Mastering React Test-Driven Development" by Daniel Irvine.
Related to DEV-83
Screenshots
Before
After
Type of change
Design Change
How Has This Been Tested?
Using Chrome Browser + Chrome Developer Tools to test various breakpoints. As well as manually clicking through links. Added and tested with unit tests to cover the components.