search

outl1ne / nova-detached-filters

This Laravel Nova package allows you to detach filters from the filter dropdown and show them on a card
MIT License
61 stars 21 forks source link

Reset filter icon. #30

Closed philipbaginski closed 2 years ago

philipbaginski commented 2 years ago

Hi!

First of all thanks for making this package alive. Great work! The only question I have, and it's not an issue, but I don't know how to make a pull request:

Is it not better - of course this is my point of view - to use old refresh icon instead of new one? The old one - refresh - looks better and gives more clear info what will happened. New one is visually unreadable.

The rest looks and works just outstanding :-)

KasparRosin commented 2 years ago

Hi! Could you share a screenshot of what your reset icons look like? I did not change any icons intentionally and on my test project, they look the same as they did in nova3.

image

philipbaginski commented 2 years ago

Hi! Could you share a screenshot of what your reset icons look like? I did not change any icons intentionally and on my test project, they look the same as they did in nova3.

image

I see the same icon like you. But old icon - regarding screenshots in the docs looks different, like standard refresh icon - see pictures in the docs.

KasparRosin commented 2 years ago

Ahh, there is slight mistake from my part here. The one in docs is actually out-dated. We changed the reset icon in release [1.0.4] (Release Notes) I'll update the docs with fresh nova 4 screenshots some time next week.

There was an internal discussion a while back, when this package was first developed, as to which icon to use and we opted to switch out the "refresh" icon, since it could have been misunderstood by new and existing nova users.

I don't think we'll change it back.