search

outl1ne / nova-detached-filters

This Laravel Nova package allows you to detach filters from the filter dropdown and show them on a card
MIT License
61 stars 21 forks source link

Problem with persisting filter selections #4

Closed goldmerc closed 4 years ago

goldmerc commented 4 years ago

2 issues -

  1. If I select some filters and then click the lock to turn it green, the filters selected before the lock is turned green are not persisted. I think from a user perspective, the expected behavior would be that after selecting filters, if the lock is turned on, those filters already selected should be persisted.

  2. If I turn on persisting and select some filters, then I navigate away from the page and come back, the filter card shows the correct filters selected but the index component does not show the correct filtered list of items. If I refresh the page, it works. What appears to be happening is that the correct items are shown for a moment and then the unfiltered list of items is loaded in over them. Interestingly the built in drop down filter shows the right number of filters and the page count at the bottom of the page, shows the right total, so I see something like '1-25 of 8'.

KasparRosin commented 4 years ago

I was unable to reproduce the 1st issue. Could you reopen it in a new issue. I will close this issue.

The 2nd issue was fixed and is included in 1.0.6. Thank you very much!

goldmerc commented 4 years ago

Both issues have resolved for me now. Thanks!