outl1ne / nova-menu-builder

This Laravel Nova package allows you to create and manage menus and menu items.
MIT License
239 stars 86 forks source link

Too few arguments to function Illuminate\Database\Schema\Builder::dropColumns() when Rolling back: 2022_04_16_000000_create_nestable_field_to_menus_table #147

Closed curder closed 2 years ago

curder commented 2 years ago

When running php artisan migrate:refresh --seed, will throw exception Too few arguments to function Illuminate\Database\Schema\Builder::dropColumns(), 1 passed in /Users/curder/Codes/nova-demo/vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php on line 337 and exactly 2 expected

<?php

use Illuminate\Support\Facades\Schema;
use Illuminate\Database\Schema\Blueprint;
use Outl1ne\MenuBuilder\MenuBuilder;
use Illuminate\Database\Migrations\Migration;

class CreateNestableFieldToMenusTable extends Migration
{
    public function up()
    {
        if (!Schema::hasColumn(MenuBuilder::getMenuItemsTableName(), 'nestable')) {
            Schema::table(MenuBuilder::getMenuItemsTableName(), function (Blueprint $table) {
                $table->boolean('nestable')->default(1);
            });
        }
    }

    public function down()
    {
        Schema::dropColumns(MenuBuilder::getMenuItemsTableName(), ['nestable']); // Add table name for the first argument.
    }
}
Tarpsvo commented 2 years ago

Thanks for reporting this! Fixed in version 7.0.4.