Added functionality - Githubissues

outl1ne / nova-notes-field

This Laravel Nova package adds a notes field to Nova's arsenal of fields.

MIT License

51 stars 36 forks source link

Added functionality #18

Closed SimonBarrettACT closed 4 years ago

SimonBarrettACT commented 4 years ago

Needed to make a couple of small changes for a project and thought that others might find these useful:

A config setting to set the input to be displayed full width
Added the ability to hide the add note input (can be displayed depending on user role/permissions)

Tarpsvo commented 4 years ago

Hi! Thanks a lot for the contribution! I added some comments regarding the code. There seemed to be some unused functions. I also requested some wording changes, if that's okay for you. Thanks again!

SimonBarrettACT commented 4 years ago

Thanks,

I'll take a look and make the changes you've requested.

Cheers Simon

SimonBarrettACT commented 4 years ago

I'm also thinking that it would be useful to provide the ability to edit notes. What do you think?

Have now made and pushed the requested changes.

It's a great custom field, really useful.

Tarpsvo commented 4 years ago

Hi! I merged it and released it in version 1.5.5.

However, I did make further changes.

1) The config option use_full_width became full_width_inputs 2) ->fullWidth(true/false) can now be called on a field instance, allowing you to make only some fields full width 3) showAddNoteButton() became addingNotesEnabled()

That should be it. Thanks a ton for your help and good luck!