search

outl1ne / nova-notes-field

This Laravel Nova package adds a notes field to Nova's arsenal of fields.
MIT License
51 stars 36 forks source link

Add feature to edit notes. #61

Closed steven-fox closed 1 year ago

steven-fox commented 1 year ago

Closes #60

This PR:

  1. Provides the backend and frontend changes necessary to edit notes.
  2. Fixes a bug where specifying "full width" doesn't make the notes full width.
  3. Updates the README.

UI/UX changes: When a given user is authorized to edit an existing note, a new [Edit] option is present next to the [Delete] option. By clicking edit, the note component transforms into the NoteInput component, permitting the ability to edit the text and click an "Update" button. Upon error, the note is still in editing form until further action occurs. Upon success, the editing session is terminated and all of the notes for the resource are refetched.

Compatibility issues: I do not believe this PR introduces any backward compatibility issues. Should be plug-and-play.

Before accepting or tagging for release, I recommend updating the lang file for et.json with the new translations.

I did my best to adhere to this package's coding strategy and style as best I could. If I find time, I might attempt a refactor (at least for the backend parts) to help make future maintenance easier.

ph1llips commented 1 year ago

Any updates on merging this? Would really be helpful.

eugenl1nde commented 1 year ago

Hey!

Merged your changes - they look solid. I'll drop the new release soon. Big thanks for chipping in!

Cheers!