outl1ne / nova-settings

A Laravel Nova tool for editing custom settings using native Nova fields.
MIT License
271 stars 99 forks source link

Save Settings button disabled or missing? #173

Closed davidvexel closed 8 months ago

davidvexel commented 8 months ago

Hi!

For some reason my save settings button is not loading properly, I think I get this placeholder but not the actual submit button, I don't have any policies or permissions configuration in place, it's just a new Nova install. Any insight?

Thanks!

image

jackfishercf commented 8 months ago

Im having the same issue

karaOdin commented 8 months ago

same issue, any help

abyshakes commented 8 months ago

Same issue here.. I had upgraded Laravel from 8 to 9 and 9 to 10 and also updated Nova to 4.28.0

abyshakes commented 8 months ago

I downgraded Nova to 4.27.14 and the Save button works.

jackfishercf commented 8 months ago

I downgraded Nova to 4.27.14 and the Save button works.

that worked for me too

davidvexel commented 8 months ago

Nice thanks all, I confirmed it works downgrading nova, there may be something funky on version 4.28 and the submit button component of Nova.

nathan-io commented 8 months ago

Also experiencing this after upgrading Nova. Thanks for the PR @alancolant, hope it's merged it.

nathan-io commented 8 months ago

Also getting this with the latest Nova 4.29.2, I don't think this issue is going to resolve on its own.

For now, we've updated composer.json to use alancolant's fork:

"require": {
     ...
     "outl1ne/nova-settings": "dev-main",
     ...
}
    "repositories": [
        {
            "type": "composer",
            "url": "https://nova.laravel.com"
        },
        {
            "type":"vcs",
            "url":"https://github.com/alancolant/nova-settings"
        }
    ]

Then composer update outl1ne/nova-settings.

alancolant commented 8 months ago

Thank you, @nathan-io , for the details. I just want to clarify that I won't have the time to keep the fork updated if the plugin evolves on its own. The only reliable long-term solution is for the pull request to be merged.

vilhelmjosander commented 8 months ago

Same issue here, would be great to get the PR merged.

beiaduo commented 8 months ago

Now nova latest version still have this issues

davidvexel commented 8 months ago

Fwiw, I noticed this issue in another Nova library, so I think it's related to the way external libraries uses the submit button from Nova.

This is the other package: https://github.com/JeffBeltran/sanctum-tokens

mstaack commented 8 months ago

oh man, once again another nova<->nova-package issue... no saving for now i guess 😞

alancolant commented 8 months ago

@davidvexel I create PR in https://github.com/JeffBeltran/sanctum-tokens with same fix

I will follow this discussion: https://github.com/laravel/nova-issues/discussions/6025 If this approach proves to be sustainable, I will make the merge request using the new package "laravel-nova-ui". I am just waiting for confirmation.

mstaack commented 8 months ago

thank you! fix works...saving is back again 🚀