outl1ne / nova-settings

A Laravel Nova tool for editing custom settings using native Nova fields.
MIT License
278 stars 97 forks source link

Introducing caching options #186

Open manuel-watchenterprise opened 5 months ago

manuel-watchenterprise commented 5 months ago

The current flow is that the singleton service class is using class property as cache ("in-memory"), however, this can cause problems in background processes (incl. Horizon / Queue) and if the app is utilising Laravel Octane.

There are 3 options now:

I will have no time to add tests, really sorry. Feel free to close this PR if that's a problem and no one can add them.

Relates to #182 .

nathan-io commented 3 months ago

Thank you! This feature is desperately needed.

Much cleaner than my current workaround for this issue.