search

outl1ne / nova-settings

A Laravel Nova tool for editing custom settings using native Nova fields.
MIT License
273 stars 97 forks source link

settings form tabs resource id fixed #77

Closed ahmetbedir closed 2 years ago

ahmetbedir commented 2 years ago

When I try to delete the image in the tab, it returns 404 error. There is no problem when I do not use it in the tab. The cause of the error is due to the path checked in the SettingsPathExists middleware. This was causing the issue because :resource-id was manually given 'settings' to the FormTab component in the Settings.vue file. When I changed this part to :resource-id="$route.params.id || 'general'" where it is used in the FormPanel, the problem was solved.

ahmetbedir commented 2 years ago

I had a similar situation to the problem here #75. This problem arises when we use it inside a tab. In other cases, I did not see a problem with deleting images. The changes will fix the problem.

Tarpsvo commented 2 years ago

That's awesome! Thanks a ton for debugging and fixing this. :) I will release it shortly.