outlandishideas / wpackagist

WordPress Packagist — manage your plugins with Composer
https://wpackagist.org
MIT License
719 stars 68 forks source link

Add core support #4

Closed Rarst closed 10 years ago

Rarst commented 11 years ago

For full site stack capability support for WP core itself is essential. It's not clear if it's going to include composer.jsonnatively (open ticket) so needs custom handling for now.

Possible sources:

Rarst commented 11 years ago

Related - opened issue in composer/installers https://github.com/composer/installers/issues/77 about possibly adding explicit wordpress-core type.

romulodl commented 11 years ago

I think Wordpress is not the core anymore (WP developers only do themes and plugins), WP is just a dependency as any other package. The best thing should make wordpress runs for a website from within the vendor folder. Then the project only would require wordpress from composer.json without any special type (as wordpress-plugin used on composer/installers).

In my opinion a good way to go would be to do something like this #=> https://github.com/markjaquith/WordPress-Skeleton but without submodules

Rarst commented 11 years ago

Unfortunately WP exposes actual path in admin URLs and it is common requirement to customize that. It is not realistic to deny such option in Composer stack - people simply won't use it.

lavoiesl commented 10 years ago

What do you think of my solution ? I symlink a bunch of files and modify ABSPATH:

https://github.com/wemakecustom/wp-skeleton/blob/master/src/WMC/Wordpress/Composer/ScriptHandler.php

Rarst commented 10 years ago

johnpbloch/wordpress (and installer it uses) had been created since and is superb WP core package. Since it's now de-facto standard I am not sure it's worth it for wpackagist to have its own core package now.

tomjn commented 10 years ago

It should also be noted that part of the reason it wasn't accepted for WP Core itself was that the extra installer would be needed to install it and Core developers weren't keen on the idea of maintaining an extra component.

lavoiesl commented 10 years ago

I completely agree, johnpbloch/wordpress is awesome.