search

outlandishideas / wpackagist

WordPress Packagist — manage your plugins with Composer
https://wpackagist.org
MIT License
695 stars 71 forks source link

Use latest pagerfanta bundle + core #490

Closed NoelLH closed 3 months ago

NoelLH commented 1 year ago

Gets us closer to ready for Symfony 6.x, while not requiring it yet

NoelLH commented 1 year ago

This (probably) works functionally but the styling / template overrides don't. We need to pick extending the new package's template blocks, or making moderately significant changes to our CSS to style the HTML it produces without customisation.

NoelLH commented 3 months ago

@rasmuswinter This turned out to be quite straightforward once I had some test data locally to see what it does.

To me it now looks about the same visually as Staging, except that clickable page numbers hovered or focused go red-on-grey instead of dark-grey-on-grey. This looks a bit higher contrast and other links are red, so I think it might be a slight improvement (although it wasn't a choice initially!), so am proposing to leave it that way on the updated PR.

I would suggest we merge this, test more and get it live if you're happy. Then it looks like only other thing blocking Symfony packages moving to 6.x is the PHP version being 8.0 in config.platform.php. The live runtime is already PHP 8.1, so if it doesn't cause you compatibility problems we should be good to also increase the minimum + emulated versions to 8.1.x to become Symfony 6 compatible.