search

outline / rich-markdown-editor

The open source React and Prosemirror based markdown editor that powers Outline. Want to try it out? Create an account:
https://www.getoutline.com
BSD 3-Clause "New" or "Revised" License
2.87k stars 592 forks source link

Peer dependency requirements of upstream library prevents install of this library with React 17 without use of --force #418

Closed brianbancroft closed 3 years ago

brianbancroft commented 3 years ago

To Reproduce Steps to reproduce the behavior: (from the command line)

  1. npx create-react-app myapp && cd myapp
  2. npm i rich-markdown-editor@latest

Expected behavior It installs

Actual behavior It doesn't install unless developer includes --force flag on all installs.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! Found: react@17.0.2
(... glossing over this part for now)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.4.0" from react-medium-image-zoom@3.1.2
npm ERR! node_modules/rich-markdown-editor/node_modules/react-medium-image-zoom
npm ERR!   react-medium-image-zoom@"^3.0.16" from rich-markdown-editor@11.6.0
npm ERR!   node_modules/rich-markdown-editor
npm ERR!     rich-markdown-editor@"11.6.0" from the root project

Version latest

Desktop (please complete the following information):

tommoor commented 3 years ago

240 and #241 both necessitate upgrading this dependency too, sounds like the time is nigh.